-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for BSD based systems (specifically, OS X with homebrew getopt #19
Conversation
Hey @wolph It seems I completely missed this PR. Thanks for taking the time to share your patch! I recently pushed some more bugfixes and changes (changelog will be updated soon, so you can follow better). It would be nice, if you can give it a test on BSD. I will try to integrate your changes from this PR as well. |
I've adopted the fix here, can you please verify it is working? |
It mostly appears to be working. But I am getting this error (although I think it's unrelated to this change):
No clue what's causing it. I already tried to update my token but no dice. |
Could you please post the terminal output? You can also try with |
I've tried to fix it via ae0a3ff |
Yes, that was probably it. The new release works perfect! Thank you for the fix :) |
I've published a new release with the fix. Could you maybe help me write some installing instructions for those systems? Mainly the command to install the dependencies and their correct name would be important. I also want to add a feature that checks the key expire date. Now I found that |
Sure, it's rather simple I believe :)
And that's it :) Optionally (if people don't have it yet)
Or an all-in-one command: |
@NicoHood still not perfectly fixed unfortunately. The issue is with quotes in |
Actually... this seems to fix it for me:
|
Can you name me a sample message, that does not work for you? I've replaced printf with jq, it should escape everything. I am wondering why this still does not work properly. |
I've recently switched to
|
Why would you do this? This message also gets attached to the tag and the github message. Did you see, that I've added automatically parsing of a changelog file in 1.4.x? I am currently working a lot on this project, including a website etc, so everything will be (hopefully) more clear soon. Maybe that feature could be useful for you too. |
Because Github doesn't show the tag commit message in the list of releases: https://github.com/WoLpH/python-utils/releases So changed it to look like this: https://github.com/WoLpH/portalocker/releases I didn't know about the changelog parsing, but I'm not using a separate changelog anyhow. The tag commit messages are my changelog. |
I am not sure if I understand correct. Did you try the Also looking at your post above you said you are using I am still wondering what useful information Did that help or am I still completely missing something? Offtopic: Is there any reason why you are tagging releases with "v" |
Let me clarify a bit :) I use
Perhaps I should replace it with
My git tags are the changelog in this case. It contains all of the relevant changes made in the releases. While I agree that dedicated changelogs are better... I know I'll forget and having an out of date changelog is worse than not having a dedicated one. Besides slightly different formatting it's effectively the same.
It's mostly legacy now to be honest. Originally it was because some software automatically tries to convert it into a number which fails because there are 2 dots. |
I think I do have a little feature request. It would be nice to be able to set the release title as well. That seems to be hardcoded to the tag right now. |
Thanks for the feedback. I've opened separated bugs for this. |
On BSD/OS X the
getopt
command works differently so instead of parsing the arguments you get the original arguments back. On previous systems I've simply changed myPATH
to fix it but I thought a better fix would be to check for it in the code :)